Update stubs with node selection methods #1101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanberthias
changed the title
| def __next__(self): ... | ||
| def __pow__(self, other): ... | ||
| def __radd__(self, other): ... | ||
| def __reduce_cython__(self, *args, **kwargs): ... |
Member
There was a problem hiding this comment.
what were these and why don't we need them anymore?
Contributor
Author
There was a problem hiding this comment.
These are symbols generated by Cython that exist at runtime so stubgen picked them up, but I don't think they are useful to have in the stubs, as I wouldn't expect anyone to try to use them. But maybe I'm wrong, in which case we can add them back 🤷
I removed most of these symbols in #1073, these are a few leftovers I missed back then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny changes to account for the recently merged PR.
It's in draft as if #1099 gets merged, there would be more changes. But if you cut the 5.7 release before merging it, this PR should be included as-is 😄